Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time skew #37

Merged
merged 1 commit into from Oct 27, 2020
Merged

Time skew #37

merged 1 commit into from Oct 27, 2020

Conversation

paigerube14
Copy link
Collaborator

PR for #22

This PR allows the user to reset the date or time on nodes and pods and validates that the time gets reset properly.

@rht-perf-ci
Copy link

Can one of the admins verify this patch?

Copy link
Collaborator

@mffiedler mffiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code looks good + tested both pod and node scenarios and the worked well.

@@ -0,0 +1,29 @@
### Time/Date Skew Scenarios
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to rename this file to time_scenarios.md to match the one being used in README.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaenr chaitanyaenr merged commit 6f31519 into krkn-chaos:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants