New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time skew #37
Time skew #37
Conversation
Can one of the admins verify this patch? |
b270eb6
to
c71be0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - code looks good + tested both pod and node scenarios and the worked well.
docs/time_skew.rd
Outdated
@@ -0,0 +1,29 @@ | |||
### Time/Date Skew Scenarios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to rename this file to time_scenarios.md to match the one being used in README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
26f7043
to
de44654
Compare
0f77d48
to
f28d0ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR for #22
This PR allows the user to reset the date or time on nodes and pods and validates that the time gets reset properly.