-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action + functional tests (no *hog tests) #382
Github Action + functional tests (no *hog tests) #382
Conversation
Have you added the secrets to this main github page already? We might want to merge the workflow and then the code changes separately to be able to run the workflow against the test changes. Thoughts? |
Paige regarding the AWS credentials and the pull secret we should ask to the management to provide us them, regarding the passwords instead we can simply generate them randomly and they will work, anyway I'm afraid that I don't have the grants to set them in the krkn repo :-\ @chaitanyaenr can you check? |
@tsebastiani sent you an invite, do let me know if it allows you to add secrets to the project. Thanks. |
I can access some settings, but not the actions and secret section apparently. |
1b0bdcf
to
efce46c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we can merge it in once rebased. Thanks. |
7abbf46
to
4b30f5f
Compare
Closes #374
This PR introduces the new functional tests GitHub Action on a disposable OpenShift instance 4.x leveraging the crc-cloud project created on purpose.
The GitHub action is triggered by commenting a pull request with the keyword
/test
(the keyword can be changed) and to make it work must be first merged in the main branch.The action will instantiate and dispose a fully functional OpenShift instance on AWS. The action will checkout the last commit in the PR branch from which the comment is added and the OpenShift instance will be disposed even if an error is encountered during the test run.
The following tests are actually executed;
The following secrets must be created in the repository :
The Action will produce a test report containing the Passed/Failed tests and the code coverage in the action summary. From my experiments the full run takes approximately 23 minutes.