Added support to kill prometheus pods #6
Conversation
|
Please have a look @chaitanyaenr |
yashashreesuresh
force-pushed
the
prometheus_pod_kill
branch
2 times, most recently
from
3ceb399
to
43e62b0
Compare
|
Can one of the admins verify this patch? |
yashashreesuresh
force-pushed
the
prometheus_pod_kill
branch
from
43e62b0
to
b411d58
Compare
|
I would add this scenario to the config file so it gets run by default, but everything else looks good to me! |
| @@ -0,0 +1,23 @@ | |||
| config: | |||
There was a problem hiding this comment.
Maybe also add a post action to check the pod count i.e 2 similar to https://github.com/openshift-scale/kraken/blob/823cecad6e801d3ee86580f1bc480c7a8ba5d237/scenarios/post_action_openshift-kube-apiserver.yml#L19?
yashashreesuresh
force-pushed
the
prometheus_pod_kill
branch
from
b411d58
to
205434f
Compare
| value: "Running" | ||
| # The actions will be executed in the order specified | ||
| actions: | ||
| - checkPodCount: |
There was a problem hiding this comment.
Is there a way to mention a timeout for the check pod count action? cc: @paigerube14
There was a problem hiding this comment.
Not that I can see, I will keep looking though
There was a problem hiding this comment.
We might want to open an issue in powerfulseal to add support to specify the retries as this will avoid maintaining two configs for the same scenario. Kill can be the first action and checkPodCount can be the next action with retries in place. Thoughts?
|
Merging this as we can revisit it after the issue that @paigerube14 opened ( powerfulseal/powerfulseal#295 ) to add retries logic to avoid having two configs to inject failures and check if the targeted component recovered. Thanks. |
Added a scenario to kill prometheus pods.