-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pod scenarios for custom app #62
Add pod scenarios for custom app #62
Conversation
config/config.yaml
Outdated
@@ -8,6 +8,8 @@ kraken: | |||
- - scenarios/etcd.yml | |||
- - scenarios/regex_openshift_pod_kill.yml | |||
- scenarios/post_action_regex.py | |||
- - scenarios/customapp_pod.yml | |||
- scenarios/post_action_customapp_pod.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliemathew we can definitely have the scenario part of the scenarios to consume in the config but we might want to delete the entry in the default config since the acme-air namespace might not exist on a default cluster. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaitanyaenr
I agree to your suggestion. Removed the entry in the config file and modified the ReadMe for 'Pod Scenarios'.
Please review. Thanks.
Can one of the admins verify this patch? |
bdf2beb
to
409d233
Compare
One small suggestion, you are kind of doing a double post action check. I would suggest picking just one. The 2 different types can be seen in the first pod_scenario section here
Please let me know if any of that doesn't make sense. |
Signed-off-by: mjulie <mjulie@in.ibm.com>
409d233
to
19a15fd
Compare
timeout: 180 | ||
|
||
actions: | ||
- checkPodCount: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliemathew we can skip the "scenarios/post_action_customapp_pod.py" action in favor of this check I guess. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I agree.
Made the changes. Please review. Thanks.
Signed-off-by: mjulie <mjulie@in.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @juliemathew.
Signed-off-by: mjulie <mjulie@in.ibm.com>
LGTM |
Signed-off-by: mjulie mjulie@in.ibm.com