Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod scenarios for custom app #62

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

juliemathew
Copy link
Contributor

Signed-off-by: mjulie mjulie@in.ibm.com

@@ -8,6 +8,8 @@ kraken:
- - scenarios/etcd.yml
- - scenarios/regex_openshift_pod_kill.yml
- scenarios/post_action_regex.py
- - scenarios/customapp_pod.yml
- scenarios/post_action_customapp_pod.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliemathew we can definitely have the scenario part of the scenarios to consume in the config but we might want to delete the entry in the default config since the acme-air namespace might not exist on a default cluster. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaitanyaenr
I agree to your suggestion. Removed the entry in the config file and modified the ReadMe for 'Pod Scenarios'.
Please review. Thanks.

@rht-perf-ci
Copy link

Can one of the admins verify this patch?

@paigerube14
Copy link
Collaborator

One small suggestion, you are kind of doing a double post action check. I would suggest picking just one.

The 2 different types can be seen in the first pod_scenario section here

  • the etcd scenario doesn't have a second item in the list and does the post action check in the yaml scenario file.

  • While the regex scenario has a python file in the list for that scenario. The regex scenario has varying number of pods so we use the python file to print the number of pods for that specific env. If you want to use a python file or bash script as the post action check, it will first run the script before the scenario to get the original number of pods before the pod killing and again after to make sure those numbers match.
    Also, if you have a varying number of pods you can print just the number of pods as seen here and kraken will take care of the rest.

Please let me know if any of that doesn't make sense.

Signed-off-by: mjulie <mjulie@in.ibm.com>
timeout: 180

actions:
- checkPodCount:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliemathew we can skip the "scenarios/post_action_customapp_pod.py" action in favor of this check I guess. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I agree.
Made the changes. Please review. Thanks.

Signed-off-by: mjulie <mjulie@in.ibm.com>
Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @juliemathew.

docs/pod_scenarios.md Outdated Show resolved Hide resolved
Signed-off-by: mjulie <mjulie@in.ibm.com>
@paigerube14
Copy link
Collaborator

LGTM

@chaitanyaenr chaitanyaenr merged commit a42adf8 into krkn-chaos:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants