Add pointer to the new blog #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Adds a pointer to a new blog which emphasizes the importance of making chaos part of Perf/Scale test runs. - Bumps up the allowed max-line-length for the linters.
|
Can one of the admins verify this patch? |
paigerube14
reviewed
Mar 18, 2021
| @@ -318,7 +318,7 @@ def main(cfg): | |||
| iterations = config["tunings"].get("iterations", 1) | |||
| daemon_mode = config["tunings"].get("daemon_mode", False) | |||
| deploy_performance_dashboards = config["performance_monitoring"].get("deploy_dashboards", False) | |||
| dashboard_repo = config["performance_monitoring"].get("repo", "https://github.com/cloud-bulldozer/performance-dashboards.git") | |||
| dashboard_repo = config["performance_monitoring"].get("repo", "https://github.com/cloud-bulldozer/performance-dashboards.git") # noqa | |||
There was a problem hiding this comment.
did you mean to add this to this commit?
There was a problem hiding this comment.
Yes, it's causing the linters to fail since it exceeds the max allowed chars per line ( 134 vs 120 ) even after the change in tox configuration.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
of making chaos part of Perf/Scale test runs.