Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank node name error message #97

Merged
merged 2 commits into from
May 6, 2021

Conversation

paigerube14
Copy link
Collaborator

Description

If the user leaves the node_name blank in the node scenario config file an error message is printed out saying it couldn't find the node. But in our default node scenario we are matching based on the label selector so this message can be confusing.
This update should only print off the error message if a node name is given and does not match and ready node names

@rht-perf-ci
Copy link

Can one of the admins verify this patch?

Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaenr chaitanyaenr merged commit 190cf5d into krkn-chaos:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants