Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm_get_src(dm())? #394

Closed
TSchiefer opened this issue Jun 5, 2020 · 1 comment · Fixed by #430
Closed

dm_get_src(dm())? #394

TSchiefer opened this issue Jun 5, 2020 · 1 comment · Fixed by #430
Milestone

Comments

@TSchiefer
Copy link
Member

Should dm_get_src(dm()) still return default_local_src() (currently .GlobalEnv) after #393, or wouldn't it be more consistent to return NULL?

@krlmlr krlmlr added this to the 0.1.6 milestone Jul 29, 2020
krlmlr added a commit that referenced this issue Jul 29, 2020
- `dm_get_src()` returns `NULL` for local data sources (#394).
- `dm` objects with local data sources no longer show the "Table source" part in the output.
krlmlr added a commit that referenced this issue Aug 19, 2020
dm 0.1.6

- `dm_get_src()` returns `NULL` for local data sources (#394).
- Local target in `copy_dm_to()` gives a deprecation message (#395).

- `copy_dm_to()` gives a better error message for bad `table_names` (#397).
- `dm` objects with local data sources no longer show the "Table source" part in the output.
- Error messages now refer to "tables", not "elements" (#413).
- New `dm_bind()` for binding two or more 'dm' objects together (#417).

- For databases, the underlying SQL table names are quoted early to avoid later SQL syntax errors (#419).
- `dm_financial()` no longer prints message about `learn_keys = FALSE`.
- `dm_rows_update()` and related functions now use the primary keys defined in `x` for establishing matching rows.

- Use `withCallingHandlers()` where appropriate (#422).
- Consistent definition of `.dm` and `.zoomed_dm` methods (#300).
- Examples involving `dm_financial()` are not run if connection can't be established (#418).
- Fix database tests on CI (#416).
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants