Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quoting of SQL identifiers #419

Merged
merged 13 commits into from
Jul 29, 2020
Merged

Improve quoting of SQL identifiers #419

merged 13 commits into from
Jul 29, 2020

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Jul 27, 2020

when fetching and deploying database. Addresses part of #23.

@krlmlr krlmlr force-pushed the f-schema-sql branch 3 times, most recently from b7fb7fa to 0de93ff Compare July 27, 2020 05:46
@krlmlr krlmlr merged commit 6701a3d into master Jul 29, 2020
@krlmlr krlmlr deleted the f-schema-sql branch July 29, 2020 05:22
krlmlr added a commit that referenced this pull request Aug 19, 2020
dm 0.1.6

- `dm_get_src()` returns `NULL` for local data sources (#394).
- Local target in `copy_dm_to()` gives a deprecation message (#395).

- `copy_dm_to()` gives a better error message for bad `table_names` (#397).
- `dm` objects with local data sources no longer show the "Table source" part in the output.
- Error messages now refer to "tables", not "elements" (#413).
- New `dm_bind()` for binding two or more 'dm' objects together (#417).

- For databases, the underlying SQL table names are quoted early to avoid later SQL syntax errors (#419).
- `dm_financial()` no longer prints message about `learn_keys = FALSE`.
- `dm_rows_update()` and related functions now use the primary keys defined in `x` for establishing matching rows.

- Use `withCallingHandlers()` where appropriate (#422).
- Consistent definition of `.dm` and `.zoomed_dm` methods (#300).
- Examples involving `dm_financial()` are not run if connection can't be established (#418).
- Fix database tests on CI (#416).
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants