Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new {datamodelr} print method does not well with tibbles #31

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

TSchiefer
Copy link
Member

library(tibble)
t <- tibble(a = rep(0, 3))

# result should be 0
length(unique(t[t$a != 0, "a"]))
#> [1] 1
df <- as.data.frame(t)

# this works as intended
length(unique(df[df$a != 0, "a"]))
#> [1] 0

Created on 2019-08-13 by the reprex package (v0.3.0)

@TSchiefer TSchiefer requested a review from krlmlr August 13, 2019 15:12
@krlmlr krlmlr merged commit 54a471f into master Aug 13, 2019
@krlmlr krlmlr deleted the b-print-data-model branch August 13, 2019 21:15
@krlmlr
Copy link
Collaborator

krlmlr commented Aug 13, 2019

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants