Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Added functionality to preserve other versions of the same package when uploading a new package. #1

Merged
merged 3 commits into from
Mar 25, 2013

Conversation

csizsek
Copy link
Contributor

@csizsek csizsek commented Mar 23, 2013

Hi Krobertson,

I am going to use your awesome tool to manage our debian packages on S3 but I needed the ability to have several different versions of the same package.

I have added this functionality to your tool as a command line option, but I did not change the default behavior so it won't mess up anyones scripts or tools that rely on deb-s3.

If you like this change or you think it can be useful for others then it would be great if you could pull my changes into the base.

I'm not a ruby programmer so please fell free to give any comments or feedback on my changes.

Best regards,
Peter Csizsek

:desc => "Whether to preserve other versions of a package " +
"in the repository when uploading one. " +
"Can be yes, or no."

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably change the flag to be a bool, so that way you just have to add "--preserve-versions" rather than "--preserve-versions=yes". Otherwise, looks good. I'll merge it in and clean up the flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make more sense, I agree.
Thanks.

krobertson added a commit that referenced this pull request Mar 25, 2013
Added functionality to preserve other versions of the same package when uploading a new package.
@krobertson krobertson merged commit fcf9e2a into krobertson:master Mar 25, 2013
@csizsek
Copy link
Contributor Author

csizsek commented Mar 25, 2013

thank you

DorianZaccaria pushed a commit to DorianZaccaria/deb-s3 that referenced this pull request Oct 12, 2016
Double-quote file paths in `Deb::S3::Package`
JoyceBabu pushed a commit to Ennexa/deb-s3 that referenced this pull request Jun 14, 2019
Ensure that a lock is made to avoid conflicts due to s3 latency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants