This repository has been archived by the owner on Jul 10, 2022. It is now read-only.
Fix manifest generation with complex versions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, a package was removed (even with preserve_versions set to true) when its version component and name was the same as another package. Instead, it should compare the full versions of the package (i.e. epoch, version, and iteration must be the same, not only the version). Also added tests for the changes.
|
Thanks for the fix and thanks for starting to add tests... lack of tests had me disappointed with myself and I plan to start back filling some of them 😄 |
krobertson
added a commit
that referenced
this pull request
Apr 25, 2014
…x-versions Fix manifest generation with complex versions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, a package was removed (even with preserve_versions set to true) when its version component and name was the same as another package.
Instead, it should compare the full versions of the package (i.e. epoch, version, and iteration must be the same, not only the version).
Also added tests for the changes.