Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of replication strategy parsing fix. #83

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

npatsakula
Copy link

The class property obviously can't be parsed by extract_replication_factor. I fixed parsing, but it's still not type safe, maybe I make a few MR later.

@krojew
Copy link
Owner

krojew commented Feb 21, 2022

To confirm - the actual problem is with extract_datacenter_replication_factor iterating over properties, not extract_replication_factor?

@npatsakula
Copy link
Author

npatsakula commented Feb 21, 2022

To confirm - the actual problem is with extract_datacenter_replication_factor iterating over properties, not extract_replication_factor?

extract_datacenter_replication_factor assumes, that properties contains only replication properties, but it's incorrect (build_replication_strategy didn't remove class property and it's still in the map).

@krojew krojew merged commit 52f31a1 into krojew:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants