Hide API password fields #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86932g4e6 Mask API password |
MichaelBengtsson
requested changes
Nov 21, 2023
There was a problem hiding this comment.
This will indeed hide the passwords, but it will also make browsers attempt to auto-complete them. Which we saw when we first introduced this in KCO. The browser would fill the username and passwords with the login credentials from the WordPress store if the merchant had this stored. Causing them to break the integration when updating the settings.
Please add a custom attribute to this that disabled auto-completion:
'custom_attributes' => array( 'autocomplete' => 'new-password', ),
You can see how its done in KCO here:
https://github.com/krokedil/klarna-checkout-for-woocommerce/blob/master/classes/class-kco-fields.php#L95-L134
mntzrr
commented
Nov 22, 2023
MichaelBengtsson
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the API password fields, password fields.