chore: support debugging devnet process #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pangssu
reviewed
Apr 11, 2023
Pangssu
reviewed
Apr 11, 2023
Dockerfile
Outdated
Comment on lines
16
to
22
| # Node | ||
| FROM alpine:3.17 as kanvas-node | ||
| COPY --from=builder /app/bin/kanvas-node /usr/local/bin | ||
|
|
||
| RUN addgroup user && \ | ||
| adduser -G user -s /bin/sh -h /home/user -D user && \ | ||
| mkdir /kanvas_log/ && \ | ||
| chown user:user /kanvas_log | ||
|
|
||
| USER user | ||
| WORKDIR /home/user/ |
There was a problem hiding this comment.
I think it's better to separate the stage for adding this.
Is this possible?
Suggested change
| # Node | |
| FROM alpine:3.17 as kanvas-node | |
| COPY --from=builder /app/bin/kanvas-node /usr/local/bin | |
| RUN addgroup user && \ | |
| adduser -G user -s /bin/sh -h /home/user -D user && \ | |
| mkdir /kanvas_log/ && \ | |
| chown user:user /kanvas_log | |
| USER user | |
| WORKDIR /home/user/ | |
| FROM alpine:3.17 as runner | |
| RUN addgroup user && \ | |
| adduser -G user -s /bin/sh -h /home/user -D user && \ | |
| mkdir /kanvas_log/ && \ | |
| chown user:user /kanvas_log | |
| USER user | |
| WORKDIR /home/user/ | |
| # Node | |
| FROM runner as kanvas-node | |
| COPY --from=builder /app/bin/kanvas-node /usr/local/bin | |
| ... |
There was a problem hiding this comment.
This code will not work and is for reference purposes only.
There was a problem hiding this comment.
I tried to remove bolierplate, please review again!
This commit helps user to debug a process which is run by docker compose. Currently, this only works on Linux. There should be another way for macOS users. Resolves: #11
chokobole
force-pushed
the
chore/support-debugging-devnet-process
branch
from
e22b1f5
to
3deec73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit helps user to debug a process which is run by docker compose. Currently, this only works on Linux. There should be another way for macOS users.
Resolves: #11