Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(base): fix comment for parallelized mapping #147

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

TomTaehoonKim
Copy link
Contributor

Description

Sorry for the late review and now #141 is merged, I've created a PR to update the comments that should have been done in #141.

This PR fixes comments for ParallelizeMapByChunkSize and ParallelizeMap.

Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole
Copy link
Contributor

CI failure is a known issue. See #129

Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit ddad613 into main Nov 2, 2023
1 of 3 checks passed
@chokobole chokobole deleted the chore/fix-comment-for-parallelize branch November 2, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants