test: enable benchmarking with rapidsnark #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
test/enable-benchmark-with-rapidsnark
branch
2 times, most recently
from
bce2229
to
42711f2
Compare
chokobole
force-pushed
the
test/enable-benchmark-with-rapidsnark
branch
from
42711f2
to
4bb1933
Compare
Insun35
reviewed
Mar 28, 2024
ashjeong
changed the title
chokobole
force-pushed
the
test/enable-benchmark-with-rapidsnark
branch
from
4bb1933
to
ca7556c
Compare
chokobole
force-pushed
the
test/enable-benchmark-with-rapidsnark
branch
2 times, most recently
from
7b31fef
to
818dd75
Compare
TomTaehoonKim
requested changes
Apr 2, 2024
This error occurrs due to the following code. See https://github.com/iden3/ffiasm/blob/f47c1cd603b97cfe5c4a38720cf0b01f4120b0d6/c/misc.hpp#L9.
chokobole
force-pushed
the
test/enable-benchmark-with-rapidsnark
branch
from
818dd75
to
a100630
Compare
dongchangYoo
reviewed
Apr 3, 2024
In alignment with our documentation standards, this commit updates instances of `Benchmark` to `Benchmarking` in files where the documentation contains more than just the result.
chokobole
force-pushed
the
test/enable-benchmark-with-rapidsnark
branch
from
a100630
to
4ba3678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes benchmarks comparing Tachyon and Rapidsnark, revealing that ours runs 10x faster than Rapidsnark!