perf(math): avoid copying twice on bigint operations #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
perf/avoid-copying-twice-on-bigint-operation
branch
3 times, most recently
from
6de07ed
to
009a5f6
Compare
ashjeong
reviewed
Apr 1, 2024
TomTaehoonKim
requested changes
Apr 1, 2024
ashjeong
changed the title
ashjeong
reviewed
Apr 2, 2024
chokobole
force-pushed
the
perf/avoid-copying-twice-on-bigint-operation
branch
from
009a5f6
to
80b6939
Compare
As a side effect, exsiting `Mul` is named to `MulExtend`.
chokobole
force-pushed
the
perf/avoid-copying-twice-on-bigint-operation
branch
from
80b6939
to
d74d8aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR avoids copying twice on
math::BigInt<N>operations