perf(crypto): avoid copying twice when returning a polynomial #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
ashjeong
changed the title
The need for this optimization stems from the internal copying that occurs
during multiplication and division between the polynomials.
With `Poly& * operand`, copying occurs twice,
so we use `Poly * operand` instead so that copying occurs just once.
```c++
Poly Func() {
Poly& poly;
Poly operand;
return poly *= operand; // copying twice
}
```
```c++
Poly Func() {
Poly& poly;
Poly operand;
return poly * operand; // copying once
}
```
chokobole
force-pushed
the
perf/avoid-copying-twice-when-returning-poly
branch
from
88aa774
to
f632757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The need for this optimization stems from the internal copying that occurs during multiplication and division between the polynomials. With
Poly& * operand, copying occurs twice, so we usePoly * operandinstead so that copying occurs just once.