perf: avoid in place operator where ineffective #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
perf/avoid-in-place-operator-where-ineffective
branch
from
6ab1f34
to
4056c5d
Compare
ashjeong
requested changes
Apr 4, 2024
tachyon/math/elliptic_curves/short_weierstrass/jacobian_point_impl.h
Outdated
Show resolved
Hide resolved
tachyon/math/elliptic_curves/short_weierstrass/jacobian_point_impl.h
Outdated
Show resolved
Hide resolved
tachyon/math/elliptic_curves/short_weierstrass/projective_point_impl.h
Outdated
Show resolved
Hide resolved
This commit enhances performance by utilizing the `c = a op b` style instead of `c = a; c inplace-op b`. While the former style is nearly as performant as the latter when `a` is movable, it becomes inefficient when operating on prime fields or points on elliptic curves that are not able to be moved. This change ensures better performance and readability, reducing 2 lines to 1. Note that irrelevant changes may occur due to this adjustment.
chokobole
force-pushed
the
perf/avoid-in-place-operator-where-ineffective
branch
from
4056c5d
to
edde91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit enhances performance by utilizing the
c = a op bstyle instead ofc = a; c inplace-op b. While the former style is nearly as performant as the latter whenais movable, it becomes inefficient when operating on prime fields or points on elliptic curves that are not able to be moved. This change ensures better performance and readability, reducing 2 lines to 1. Note that irrelevant changes may occur due to this adjustment.