fix: change compile option maxvx512f to mavx2 for goldilocks
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
This is to resolve a runtime error of Goldilocks when building with g++-12 and optimization mode. Plus, if we want to build with avx512, we need to add `defines = ["__AVX512__"]`, too. See https://github.com/0xPolygonHermez/zkevm-prover/blob/93c36f120c3201bfaf12b8f6f2796f53e72193ff/Makefile#L31-L37 for more details. Related: #370
chokobole
force-pushed
the
fix/change-compiler-option-to-mavx2-for-goldilocks
branch
from
df1ed87
to
6ec463b
Compare
|
Fixes the following tests that fail: |
chokobole
added a commit
that referenced
this pull request
Apr 20, 2024
Insun35
pushed a commit
that referenced
this pull request
Apr 23, 2024
Insun35
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to resolve a runtime error of Goldilocks when building with g++-12 and optimization mode.
Plus, if we want to build with avx512, we need to add
defines = ["__AVX512__"], too.See
https://github.com/0xPolygonHermez/zkevm-prover/blob/93c36f120c3201bfaf12b8f6f2796f53e72193ff/Makefile#L31-L37 for more details.