perf: avoid copying on semigroup operations #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
perf/avoid-copying-on-semigroup-operations
branch
12 times, most recently
from
92e19cc
to
250cb3e
Compare
ashjeong
reviewed
Apr 8, 2024
There was a problem hiding this comment.
change 4 commits:
Avoid copying twice on …
->
Avoid copying twice in …
Can the commit 4db1ac3 be moved to before “avoid copying twice on addition” for continuity?
a3b6bb3
refac(math): refactor fast retrun case of polynomial operations
->
refac(math): refactor fast return case of polynomial operations
ashjeong
reviewed
Apr 9, 2024
chokobole
force-pushed
the
perf/avoid-copying-on-semigroup-operations
branch
from
250cb3e
to
37933a1
Compare
ashjeong
reviewed
Apr 11, 2024
chokobole
force-pushed
the
perf/avoid-copying-on-semigroup-operations
branch
2 times, most recently
from
b73c402
to
58633c0
Compare
TomTaehoonKim
requested changes
Apr 11, 2024
tachyon/math/polynomials/univariate/univariate_evaluations_ops.h
Outdated
Show resolved
Hide resolved
chokobole
force-pushed
the
perf/avoid-copying-on-semigroup-operations
branch
from
58633c0
to
eea10b9
Compare
chokobole
force-pushed
the
perf/avoid-copying-on-semigroup-operations
branch
from
eea10b9
to
38ba29f
Compare
chokobole
added a commit
that referenced
this pull request
Apr 12, 2024
chokobole
added a commit
that referenced
this pull request
Apr 13, 2024
chokobole
added a commit
that referenced
this pull request
Apr 16, 2024
chokobole
added a commit
that referenced
this pull request
Apr 16, 2024
chokobole
added a commit
that referenced
this pull request
Apr 16, 2024
chokobole
added a commit
that referenced
this pull request
Apr 16, 2024
chokobole
added a commit
that referenced
this pull request
Apr 16, 2024
chokobole
added a commit
that referenced
this pull request
Apr 17, 2024
chokobole
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR avoids copying on semigroup operations, which are
Add(),Mul(),Double()andSquare().