test: run (I)FFT benchmark under uniform conditions #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
ashjeong
reviewed
Apr 8, 2024
ashjeong
reviewed
Apr 11, 2024
tachyon/c/math/polynomials/univariate/bn254_univariate_evaluation_domain.h
Show resolved
Hide resolved
This commit ensures that both arkworks and Tachyon perform FFT benchmarks without incurring any copy overhead. Previously, arkworks (I)FFT didn't incur any copy overhead, while Tachyon did. Now, both implementations are configured to avoid copy overhead for consistency and accurate benchmarking.
chokobole
force-pushed
the
test/enable-fft-benchamrk-accurately
branch
from
ee07ac7
to
59d92f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit ensures that both arkworks and Tachyon perform FFT benchmarks without incurring any copy overhead. Previously, arkworks (I)FFT didn't incur any copy overhead, while Tachyon did. Now, both implementations are configured to avoid copy overhead for consistency and accurate benchmarking.