-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac(zk): refactor circuit polynomial builder #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
44e9625
refac(zk): change set_id
to j
for consistency
->
refac(zk): change set_idx
to j
for consistency
7bdf930
refac(zk): sort member variable in a order of usage
->
refac(zk): sort member variables in a order of usage
7bdf930
I think it should be in the order theta, gamma, beta if the order is based on usage; however, why don’t we just squash this with 6c7e174 since we over write part of this commit?
& If this is changed, I think EvaluationInput constructor should also be changed (aka use in line 267)
Previously, the progress was displayed as (0 / 0), and now it's changed to (1 / 1).
I agree with the first and second points. But For the third point, yeap, I also noticed that I should've changed |
5e6b971
to
d742867
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d742867
to
d661376
Compare
d661376
to
f179bbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR refactors(mostly) and optimizes
CircuitPolynomialBulider