Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(math): add circle point initially #387

Merged
merged 16 commits into from
Apr 22, 2024
Merged

feat(math): add circle point initially #387

merged 16 commits into from
Apr 22, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR adds CirclePoint and CirclePointIndex initially for CircleSTARK.

@chokobole chokobole force-pushed the feat/add-circle-point-initially branch 8 times, most recently from 11ebd2e to 1bfc852 Compare April 16, 2024 14:35
@chokobole chokobole marked this pull request as ready for review April 16, 2024 14:35
@chokobole chokobole force-pushed the feat/add-circle-point-initially branch 4 times, most recently from 3f516c0 to 6524c11 Compare April 17, 2024 11:19
@chokobole chokobole force-pushed the feat/add-circle-point-initially branch from 6524c11 to b3e8de9 Compare April 18, 2024 04:33
Insun35
Insun35 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomTaehoonKim
TomTaehoonKim approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole
feat(math): ensure value is within range when creating Goldilocks o…
ebe8d92 
…n debug mode
@chokobole
feat(math): implement extended Euclidean algorithm
9c3a315 
See https://en.wikipedia.org/wiki/Extended_Euclidean_algorithm.
@chokobole
perf(math): ensure montgomery conversion called at most once for `Gol…
e35fb9f 
…dilocks`

Previously, `Goldilocks::FromMontgomery()` behaved differently depending on
the value of `USE_MONTGOMERY`. This update standardizes the behavior
as follows:

when `USE_MONTGOMERY == 1`, no conversion is called, and when
`USE_MONTGOMERY != 1`, `::Goldilocks::from_montgomery()` is called.

This ensures that Montgomery conversion is invoked at most once,
optimizing performance.
@chokobole
refac(math): change internal methods to private
39cb858
@chokobole
refac(math): remove unused header
101386e
@chokobole chokobole force-pushed the feat/add-circle-point-initially branch from b3e8de9 to 218c028 Compare April 18, 2024 14:59
ashjeong
ashjeong requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

27097ee
test(math): sample elements for inversion until non-zero elements
->
test(math): sample elements for inversion until reaching non-zero elements
97644a1
apply fast multiplication by non-reisude on specific condi…
…tion
-> apply fast multiplication by non-residue on specific condi…
…tion

tachyon/math/circle/circle_point.h Show resolved Hide resolved
tachyon/math/circle/circle_point.h Show resolved Hide resolved
tachyon/math/circle/circle_point_forward.h Show resolved Hide resolved
tachyon/math/circle/circle_point_unittest.cc Outdated Show resolved Hide resolved
tachyon/math/circle/generator/BUILD.bazel Show resolved Hide resolved
tachyon/math/circle/generator/BUILD.bazel Show resolved Hide resolved
tachyon/math/circle/generator/generator.cc Outdated Show resolved Hide resolved
tachyon/math/finite_fields/generator/prime_field_generator/config.h.tpl Outdated Show resolved Hide resolved
tachyon/math/finite_fields/small_prime_field_generic.h Outdated Show resolved Hide resolved
tachyon/math/finite_fields/small_prime_field_generic.h Show resolved Hide resolved
@chokobole
feat(math): add class for small-sized PrimeField
8408473 
This feature introduces a new class for prime fields with less than
32-bit 1 limb. Instances of this class utilize a custom reduction method,
distinct from Montgomery reduction, to accommodate their smaller size.
@chokobole
refac(math): remove unused headers
e2ce08a
@chokobole
refac(math): replace std::to_string with recommended methods
51768f9
@chokobole
chore: fix error log
19ba841
@chokobole
build: add "@com_google_absl//absl/strings" to deps explicitly
e1812c0 
Since "absl/strings/str_replace.h" is included in the generator, it adds
"@com_google_absl//absl/strings" to the dependencies explicitly, too.
@chokobole chokobole force-pushed the feat/add-circle-point-initially branch from 218c028 to 9076f80 Compare April 19, 2024 09:06
@chokobole
feat(math): add Circle and CirclePoint
c69568b 
See
https://github.com/starkware-libs/stwo/blob/d75d283ce5d16390673ac935fb1e828c795edada/src/core/circle.rs.
@chokobole
test(math): sample elements for inversion until reaching non-zero ele…
7ff5b5d 
…ments
@chokobole
build(math): change base_field and base_field_hdr to mandatory fi…
91c11f9 
…elds
@chokobole
feat: enable extension field generation correctly with given degree
060891c
@chokobole
fix(math): apply fast multiplication by non-residue on specific condi…
49436fb 
…tion

Additionally, this corrects a comment referring to the section
in the research paper.

See
https://github.com/arkworks-rs/algebra/blob/97c7a4f4e8f5e297e397f6de09fe4764068deac0/ff/src/fields/models/fp4.rs#L11
and
https://github.com/arkworks-rs/algebra/blob/97c7a4f4e8f5e297e397f6de09fe4764068deac0/ff/src/fields/models/fp12_2over3over2.rs#L19.
@chokobole
feat(math): add G4 which corresponds to Circle<SecureField> in stwo
7bbe48f 
See
https://github.com/starkware-libs/stwo/blob/d75d283ce5d16390673ac935fb1e828c795edada/src/core/circle.rs.
@chokobole chokobole force-pushed the feat/add-circle-point-initially branch from 9076f80 to 7bbe48f Compare April 21, 2024 13:16
ashjeong
ashjeong approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongchangYoo
dongchangYoo approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongchangYoo dongchangYoo merged commit 8a5f6ce into main Apr 22, 2024
3 checks passed
@dongchangYoo dongchangYoo deleted the feat/add-circle-point-initially branch April 22, 2024 08:32
chokobole added a commit that referenced this pull request Apr 23, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
0cf0da2 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
chokobole added a commit that referenced this pull request Apr 23, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
60e1062 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
chokobole added a commit that referenced this pull request Apr 23, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
e67f22f 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
chokobole added a commit that referenced this pull request Apr 23, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
11c2b6b 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
chokobole added a commit that referenced this pull request Apr 24, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
dbdbf3b 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
chokobole added a commit that referenced this pull request Apr 25, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
b91dccc 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
chokobole added a commit that referenced this pull request Apr 25, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
13338bf 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
chokobole added a commit that referenced this pull request Apr 25, 2024
@chokobole
docs: mark Mersenne31 that is implemented for GPU
47e6217 
Since #387, `Mersenne31` is instantiated with
`small_prime_field_generic.h` and all the mathematical methods become
constexpr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@Insun35 Insun35 Insun35 approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chokobole @dongchangYoo @Insun35 @TomTaehoonKim @ashjeong