Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update tachyon vs halo2 benchmarking results #395

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

ashjeong
Copy link
Contributor

Benchmarking results are updated with Tachyon @ commit 2c6c4c4

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashjeong ashjeong force-pushed the docs/update-tachyon-vs-halo2-benchmarking-results branch from 7ce7b1c to 48386ca Compare April 19, 2024 09:54
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole
Copy link
Contributor

How do you think changing filename to README.md, so that people can see this when they navigate to tachyon/zk/plonk/halo2?

@ashjeong ashjeong force-pushed the docs/update-tachyon-vs-halo2-benchmarking-results branch from 48386ca to 0074d30 Compare April 21, 2024 10:58
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 4c04a4b into main Apr 22, 2024
3 checks passed
@chokobole chokobole deleted the docs/update-tachyon-vs-halo2-benchmarking-results branch April 22, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants