Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac(math): rename filenames #399

Merged
merged 2 commits into from
Apr 25, 2024
Merged

refac(math): rename filenames #399

merged 2 commits into from
Apr 25, 2024

Conversation

chokobole
Copy link
Contributor

@chokobole chokobole commented Apr 22, 2024

Description

This refactor renames the following files:

  • prime_field_generic.h to prime_field_fallback.h: This file is enabled when there's no optimized assembly code for the building architecture, hence the name fallback.
  • small_prime_field_generic.h to small_prime_field.h: This file is enabled for all prime fields whose modulus is less than 32 bits, hence the simplified name.

Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…neric.h`

This refactor renames the following files:

- `prime_field_generic.h` to `prime_field_fallback.h`:
   This file is enabled when there's no optimized assembly code
   for the building architecture, hence the name fallback.
- `small_prime_field_generic.h` to `small_prime_field.h`:
  This file is enabled for all prime fields whose modulus is less than 32 bits,
  hence the simplified name.
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 7995d16 into main Apr 25, 2024
3 checks passed
@chokobole chokobole deleted the refac/rename-filenames branch April 25, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants