perf(math): add fast reduction for a special case #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
perf/add-fast-reduction-for-a-special-case
branch
from
fb27825
to
942a018
Compare
Insun35
reviewed
Apr 25, 2024
tachyon/math/finite_fields/generator/prime_field_generator/build_defs.bzl
Outdated
Show resolved
Hide resolved
chokobole
force-pushed
the
perf/add-fast-reduction-for-a-special-case
branch
2 times, most recently
from
9ce1477
to
c91d49c
Compare
chokobole
force-pushed
the
perf/add-fast-reduction-for-a-special-case
branch
4 times, most recently
from
1f8fba8
to
abdbe03
Compare
Insun35
reviewed
Apr 26, 2024
chokobole
force-pushed
the
perf/add-fast-reduction-for-a-special-case
branch
from
abdbe03
to
147b76a
Compare
TomTaehoonKim
requested changes
Apr 26, 2024
|
Can you fix the commit message of c767c64 from |
chokobole
force-pushed
the
perf/add-fast-reduction-for-a-special-case
branch
from
147b76a
to
16e24c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements followings
addition,subtractionandnegationwhen the modulus of the prime field is less than 2³¹ + 1.Reduce()function calls