feat(math): add baby and koala bear fields #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
feat/add-baby-and-koala-bear-fields
branch
3 times, most recently
from
a2a5225
to
ed4c61b
Compare
TomTaehoonKim
requested changes
May 2, 2024
tachyon/math/finite_fields/mersenne31/packed_mersenne31_avx2.cc
Outdated
Show resolved
Hide resolved
tachyon/math/finite_fields/generator/prime_field_generator/build_defs.bzl
Outdated
Show resolved
Hide resolved
Insun35
reviewed
May 2, 2024
Insun35
reviewed
May 2, 2024
chokobole
force-pushed
the
feat/add-baby-and-koala-bear-fields
branch
2 times, most recently
from
8e1026e
to
e78c839
Compare
|
In commit body of 8df7697, typo exists. Please fix |
dongchangYoo
requested changes
May 6, 2024
chokobole
force-pushed
the
feat/add-baby-and-koala-bear-fields
branch
from
e78c839
to
79fa9f0
Compare
ashjeong
reviewed
May 8, 2024
There was a problem hiding this comment.
Please fix the commit title and body of 8df7697 as such:
chore(math): update comments to contain montgomery form & fix minor errors
For the 31-bit prime field, the montgomery form is a * R, where R is 2³² , so value a can be in the range {0, ..., p}, where p is the modulus. The
comments are also updated to handle this case.
Additionally, this commit also contains minor fixes, such as changing P
to p and removing commas and periods.
tachyon/math/finite_fields/mersenne31/packed_mersenne31_avx2.cc
Outdated
Show resolved
Hide resolved
tachyon/math/finite_fields/mersenne31/packed_mersenne31_avx2.cc
Outdated
Show resolved
Hide resolved
tachyon/math/finite_fields/mersenne31/packed_mersenne31_avx2.cc
Outdated
Show resolved
Hide resolved
chokobole
force-pushed
the
feat/add-baby-and-koala-bear-fields
branch
2 times, most recently
from
c1648d4
to
f9313a2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
chokobole
force-pushed
the
feat/add-baby-and-koala-bear-fields
branch
from
f9313a2
to
fd9f1dd
Compare
…rrors
For the 31-bit prime field, the montgomery form is `a * R`, where R is 2³²,
so value `a` can be in the range {0, ..., p}, where p is modulus.
The comments are also updated to handle this case.
Additionally, this commit also contains minor fixes, such as changing `P`
to `p` and removing commas and periods.
See https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/baby-bear/src/x86_64_avx2/packing.rs, https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/baby-bear/src/x86_64_avx512/packing.rs and https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/baby-bear/src/aarch64_neon/packing.rs.
See https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/koala-bear/src/x86_64_avx2/packing.rs, https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/koala-bear/src/x86_64_avx512/packing.rs and https://github.com/Plonky3/Plonky3/blob/6034010ae178439fffee55fd71f8105f62577a35/koala-bear/src/aarch64_neon/packing.rs.
chokobole
force-pushed
the
feat/add-baby-and-koala-bear-fields
branch
from
fd9f1dd
to
8281077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds baby bear and koala bear prime fields.