Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add build option to disable assembly optimized field #406

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

chokobole
Copy link
Contributor

Description

@zkbitcoin reported in Tachyon Discussion group that he has a trouble with using tachyon with ffiasm on. In order to resolve the issue, this commit adds a build option without ffiasm.

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkbitcoin reported in Tachyon Discussion group that he has a trouble
with using tachyon with ffiasm on. In order to resolve the issue, this
commit adds a build option without ffiasm.
- Remove invalid link.
- Add `--config ${os}`
@chokobole chokobole force-pushed the build/add-build-option-without-ffiasm branch from b378e41 to a21325a Compare April 29, 2024 08:01
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 3a12deb into main Apr 30, 2024
3 checks passed
@chokobole chokobole deleted the build/add-build-option-without-ffiasm branch April 30, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants