Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.bundle file is in incorrect build phase #12

Closed
fengye opened this issue Aug 17, 2013 · 3 comments
Closed

.bundle file is in incorrect build phase #12

fengye opened this issue Aug 17, 2013 · 3 comments

Comments

@fengye
Copy link

fengye commented Aug 17, 2013

Using add_file() to add .bundle to pbxproj will render the bundle not included in build phase.

See mod_pbxproj.py, line 192

if os.path.isdir(self.get('path')) and ext != '.framework':

it only take cares of .framework. I changed it to

if os.path.isdir(self.get('path')) and ext != '.framework' and ext != '.bundle':

Problem solved.

@kronenthaler
Copy link
Owner

thanks for point it out. If you make a pull request for it, i will merge it!

@JohnBueno
Copy link

Was this ever corrected? I am running into the same problem however I think I am in a different version because I don't see the os.path.isdir(self.get('path')) and ext != '.framework': line

@kronenthaler
Copy link
Owner

The fix was included while ago. Most likely you need to update your version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants