[nozzle] move away from strncpy to make coverity and gcc10 happy

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
kronosnet · Jan 21, 2020 · ae1caca · ae1caca
1 parent 5bd3c7d
commit ae1caca
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/libnozzle/libnozzle.c b/libnozzle/libnozzle.c
@@ -109,7 +109,7 @@ static void destroy_iface(nozzle_t nozzle)
 
 #ifdef KNET_BSD
 	memset(&ifr, 0, sizeof(struct ifreq));
-	strncpy(ifname, nozzle->name, IFNAMSIZ);
+	memmove(ifname, nozzle->name, IFNAMSIZ);
 
 	ioctl(lib_cfg.ioctlfd, SIOCIFDESTROY, &ifr);
 #endif
@@ -127,7 +127,7 @@ static int get_iface_mtu(const nozzle_t nozzle)
 	struct ifreq ifr;
 
 	memset(&ifr, 0, sizeof(struct ifreq));
-	strncpy(ifname, nozzle->name, IFNAMSIZ);
+	memmove(ifname, nozzle->name, IFNAMSIZ);
 
 	err = ioctl(lib_cfg.ioctlfd, SIOCGIFMTU, &ifr);
 	if (err) {
@@ -155,7 +155,7 @@ static int get_iface_mac(const nozzle_t nozzle, char **ether_addr)
 
 	memset(&mac, 0, MACADDR_CHAR_MAX);
 	memset(&ifr, 0, sizeof(struct ifreq));
-	strncpy(ifname, nozzle->name, IFNAMSIZ);
+	memmove(ifname, nozzle->name, IFNAMSIZ);
 
 #ifdef KNET_LINUX
 	err = ioctl(lib_cfg.ioctlfd, SIOCGIFHWADDR, &ifr);
@@ -523,7 +523,7 @@ nozzle_t nozzle_open(char *devname, size_t devname_size, const char *updownpath)
 		savederrno = EBUSY;
 		goto out_error;
 	}
-	strncpy(devname, curnozzle, IFNAMSIZ);
+	memmove(devname, curnozzle, IFNAMSIZ);
 	memmove(nozzle->name, curnozzle, IFNAMSIZ - 1);
 #endif
 
@@ -547,7 +547,7 @@ nozzle_t nozzle_open(char *devname, size_t devname_size, const char *updownpath)
 		goto out_error;
 	}
 
-	strncpy(devname, ifname, IFNAMSIZ);
+	memmove(devname, ifname, IFNAMSIZ);
 	memmove(nozzle->name, ifname, IFNAMSIZ - 1);
 #endif
 
@@ -732,7 +732,7 @@ int nozzle_set_up(nozzle_t nozzle)
 	}
 
 	memset(&ifr, 0, sizeof(struct ifreq));
-	strncpy(ifname, nozzle->name, IFNAMSIZ);
+	memmove(ifname, nozzle->name, IFNAMSIZ);
 
 	err = ioctl(lib_cfg.ioctlfd, SIOCGIFFLAGS, &ifr);
 	if (err) {
@@ -777,7 +777,7 @@ int nozzle_set_down(nozzle_t nozzle)
 	}
 
 	memset(&ifr, 0, sizeof(struct ifreq));
-	strncpy(ifname, nozzle->name, IFNAMSIZ);
+	memmove(ifname, nozzle->name, IFNAMSIZ);
 
 	err = ioctl(lib_cfg.ioctlfd, SIOCGIFFLAGS, &ifr);
 	if (err) {
@@ -878,7 +878,7 @@ int nozzle_set_mac(nozzle_t nozzle, const char *ether_addr)
 	}
 
 	memset(&ifr, 0, sizeof(struct ifreq));
-	strncpy(ifname, nozzle->name, IFNAMSIZ);
+	memmove(ifname, nozzle->name, IFNAMSIZ);
 #ifdef KNET_LINUX
 	err = ioctl(lib_cfg.ioctlfd, SIOCGIFHWADDR, &ifr);
 	if (err) {
@@ -1025,7 +1025,7 @@ int nozzle_set_mtu(nozzle_t nozzle, const int mtu)
 	}
 
 	memset(&ifr, 0, sizeof(struct ifreq));
-	strncpy(ifname, nozzle->name, IFNAMSIZ);
+	memmove(ifname, nozzle->name, IFNAMSIZ);
 	ifr.ifr_mtu = mtu;
 
 	err = ioctl(lib_cfg.ioctlfd, SIOCSIFMTU, &ifr);