Skip to content

Commit

Permalink
build: --export-dynamic is needed for dlopened modules only
Browse files Browse the repository at this point in the history
Not that it matters on ELF platforms the least.  If Kronosnet is ever
ported to Windows, however...

Signed-off-by: Ferenc Wágner <wferi@debian.org>
  • Loading branch information
wferi committed Jan 29, 2018
1 parent f55a138 commit f77b5f3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions libknet/Makefile.am
Expand Up @@ -85,7 +85,6 @@ EXTRA_libknet_la_DEPENDENCIES = $(SYMFILE)

libknet_la_LDFLAGS = $(AM_LDFLAGS) \
-Wl,--version-script=$(srcdir)/$(SYMFILE) \
--export-dynamic \
-Wl,-rpath=$(pkglibdir) \
-version-number $(libversion)

Expand All @@ -95,7 +94,7 @@ libknet_la_LIBADD = $(PTHREAD_LIBS) $(dl_LIBS) $(rt_LIBS) $(m_LIBS)
pkglib_LTLIBRARIES =

# MODULE_LDFLAGS would mean a target-specific variable for Automake
MODULELDFLAGS = $(AM_LDFLAGS) -module -avoid-version
MODULELDFLAGS = $(AM_LDFLAGS) -module -avoid-version -export-dynamic

if BUILD_COMPRESS_ZLIB
pkglib_LTLIBRARIES += compress_zlib.la
Expand Down
1 change: 0 additions & 1 deletion libtap/Makefile.am
Expand Up @@ -38,7 +38,6 @@ EXTRA_libtap_la_DEPENDENCIES = $(SYMFILE)

libtap_la_LDFLAGS = $(AM_LDFLAGS) \
-Wl,-version-script,$(srcdir)/$(SYMFILE) \
--export-dynamic \
-version-number $(libversion)

TESTS = $(check_PROGRAMS)
Expand Down

0 comments on commit f77b5f3

Please sign in to comment.