[transports] use SO_REUSEADDR only for sctp

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
kronosnet · Feb 25, 2020 · ffaaab3 · ffaaab3
1 parent ab72f92
commit ffaaab3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/libknet/transport_common.c b/libknet/transport_common.c
@@ -349,15 +349,6 @@ int _configure_transport_socket(knet_handle_t knet_h, int sock, struct sockaddr_
 #endif
 	}
 
-	value = 1;
-	if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &value, sizeof(value)) < 0) {
-		savederrno = errno;
-		err = -1;
-		log_err(knet_h, KNET_SUB_TRANSPORT, "Unable to set %s reuseaddr: %s",
-			type, strerror(savederrno));
-		goto exit_error;
-	}
-
 exit_error:
 	errno = savederrno;
 	return err;

diff --git a/libknet/transport_sctp.c b/libknet/transport_sctp.c
@@ -169,6 +169,15 @@ static int _configure_sctp_socket(knet_handle_t knet_h, int sock, struct sockadd
 		goto exit_error;
 	}
 
+	value = 1;
+	if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &value, sizeof(value)) < 0) {
+		savederrno = errno;
+		err = -1;
+		log_err(knet_h, KNET_SUB_TRANSPORT, "Unable to set reuseaddr on socket %d: %s",
+			sock, strerror(savederrno));
+		goto exit_error;
+	}
+
 	value = 1;
 	if (setsockopt(sock, level, SCTP_NODELAY, &value, sizeof(value)) < 0) {
 		savederrno = errno;