feat(ShowCode): Ajoute la fonctionnalité Show Code de storybook addon-docs #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-gendron
force-pushed
the
dev/DE-81
branch
from
7206660
to
8eb3de5
Compare
meriouma
approved these changes
May 7, 2020
| { | ||
| test: /\.tsx?$/, | ||
| use: [{ | ||
| loader: 'ts-loader', | ||
| options: { | ||
| transpileOnly: false, | ||
| ignoreDiagnostics: [7005] |
There was a problem hiding this comment.
T'as essayé de mettre à jour storybook à la place? La dernière c'est 5.3.18 et il y a l'air d'avoir quelques références à ça dans les versions patch de 5.3
There was a problem hiding this comment.
Je viens d'essayer et ça enable pas le showcode seulement en faisant l'update. L'update à 5.3 est dans le backlog JIRA, ça devrait donc être fait prochainement avec l'ajout des fonctionnalités intéressantes.
jni-
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Ce PR active la fonctionnalité Show Code de
@storybook/addon-docs. Jusqu'à présent, le message no code available _ apparaissait dans le bas de chaque stories.Le fait d'activer cette feature de
addon-docsgénère des erreurs TypeScript (Github issue). J'ai ajoutéignoreDiagnostics: [7005]à la config webpack dets-loaderet j'ai retirer lenoEmitOnErrordanstsconfig. Avec ces modifications les type checking fonctionne toujours dans storybook.J'ai aussi refactor quelques stories pour que la feature fonctionne bien.