refactor(Link): remove unused attributes and duplicated code #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
meriouma
approved these changes
May 12, 2023
| @@ -807,10 +789,9 @@ exports[`BentoMenuButton Matches Snapshot (productGroups and externalLinks) 1`] | |||
| <li> | |||
| <a | |||
| aria-disabled="true" | |||
| class="c24 c25 c20 c21" | |||
| class="c24 c19 c20 c21" | |||
There was a problem hiding this comment.
J'ai pas réussi à trouver l'impact visuel, mais je pense pas que ce bloc soit sur une de ces classes 🤔
.c25:visited {
color: #62a;
}
There was a problem hiding this comment.
Ah c'est que le style est override dans le bento, ça servait déjà pas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-714
L'élément
<a>généré par les composants<RouteLink>et<ExternalLink>contiennent un attributtypeerroné. Cet attribut existe dans la spec mais devrait contenir un mimetype s'il est utilisé. L'attribut en question a été retiré car il n'était pas utilisé.De plus, certains attributs sont désuets depuis la migration à react-router v6 (
activeClassName).Finalement, certaines déclarations de style étaient dupliquées dans plusieurs types de liens. Elles ont été ramenées dans le composant abstrait
<StyledLink>.Tests fonctionnels