Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny Nerf Colab Evaluation Bug #36

Open
johnmaxh opened this issue Apr 18, 2022 · 0 comments
Open

Tiny Nerf Colab Evaluation Bug #36

johnmaxh opened this issue Apr 18, 2022 · 0 comments

Comments

@johnmaxh
Copy link

It looks like when evaluating the loss in the last cell of the colab, the code uses
loss = torch.nn.functional.mse_loss(rgb_predicted, target_img)

But believe this should actually be
loss = torch.nn.functional.mse_loss(rgb_predicted, testimg)

Since we use testpose for rgb_predicted we should compare to testimg not target_img, which is just a random training sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant