Adding Support For Default DataSource and Removing Monitoring Agent #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhar316
added
the
kruize-local
shekhar316
changed the title
|
@shekhar316 Please fix the conflicts. |
shekhar316
changed the title
|
ok |
dinogun
reviewed
Mar 25, 2024
| @@ -336,6 +336,7 @@ private Memory() { | |||
|
|
|||
| public static class DataSourceConstants { | |||
| public static final String DATASOURCE_NAME = "name"; | |||
| public static final String DEFAULT_DATASOURCE_NAME = "prometheus"; | |||
There was a problem hiding this comment.
Please keep the naming consistent, this should be DEFAULT_DATASOURCE_PROVIDER
There was a problem hiding this comment.
@dinogun It's the name of the datasource which should be default. Originally, the monitoring agent was always linked to a datasource named "prometheus". Now, "prometheus" is the default name for the default datasource, but it can be changed to something else if desired.
dinogun
reviewed
Mar 25, 2024
| @@ -29,7 +29,7 @@ private KruizeSupportedTypes() { } | |||
| public static final Set<String> DIRECTIONS_SUPPORTED = | |||
| new HashSet<>(Arrays.asList("minimize", "maximize")); | |||
|
|
|||
| public static final Set<String> MONITORING_AGENTS_SUPPORTED = | |||
| public static final Set<String> DATASOURCES_SUPPORTED = | |||
There was a problem hiding this comment.
This should be DATASOURCE_PROVIDERS_SUPPORTED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add the support for setting up the
default datasourceinstead of monitoring agent. Default datasource will use the newly implementedDataSourceInfoclass objects.Type of change
How has this been tested?
Using kruize-demo scripts.
Image:
quay.io/rh-ee-shesaxen/autotune:kruize-local-ma-0Test Configuration
Checklist 馃幆
Additional information
Remote Monitoring Demo Logs: https://pastebin.com/8JtWxsi5