Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kruize local API documentation #1174

Merged
merged 7 commits into from
May 17, 2024

Conversation

shreyabiradar07
Copy link
Contributor

@shreyabiradar07 shreyabiradar07 commented Apr 22, 2024

This PR has the documentation changes for Kruize Local Monitoring usecase, with following APIs documented

  • List Datasources API
  • Import Metadata API
  • List Metadata API
  • Delete Metadata API
  • Create Experiment API
  • List Experiments API
  • Generate Recommendations API

@shreyabiradar07 shreyabiradar07 changed the base branch from master to mvp_demo April 22, 2024 11:21
@shreyabiradar07 shreyabiradar07 self-assigned this Apr 22, 2024
@shreyabiradar07 shreyabiradar07 added local_monitoring kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase labels Apr 22, 2024
@rbadagandi1 rbadagandi1 added remote_monitoring and removed local_monitoring kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase labels Apr 24, 2024
@rbadagandi1 rbadagandi1 added this to the Kruize 0.0.21_rm Release milestone Apr 24, 2024
@rbadagandi1 rbadagandi1 added kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase and removed kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase labels Apr 24, 2024
Copy link
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyabiradar07 - Can you check the formatting, listDatasources API example response has all the remaining content within it (including other APIs)

@shreyabiradar07
Copy link
Contributor Author

@shreyabiradar07 - Can you check the formatting, listDatasources API example response has all the remaining content within it (including other APIs)

fixed the formatting issue


`curl -H 'Accept: application/json' "http://<URL>:<PORT>/dsmetadata?datasource=<datasource_name>&cluster_name=<cluster_name>&verbose=true"`

Returns the container-level metadata of all the namespaces present in the specified cluster name and datasource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the difference with and without verbose more clearly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description for verbose parameter


example

`curl --location --request POST 'http://127.0.0.1:8080/generateRecommendations?interval_end_time=2023-01-02T00:15:00.000Z&experiment_name=temp_1'`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to provide an example without the interval_end_time. Also use http://<URL>:<PORT>/ insead of http://127.0.0.1:8080

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain what is returned when interval_end_time is not specified

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included an example for case where interval_end_time is not specified

Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 98dc2a1 into kruize:mvp_demo May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants