Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Import Metadata actions #1178

Merged
merged 18 commits into from
Jun 26, 2024
Merged

Multiple Import Metadata actions #1178

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
46ce94c
Add delete metadata by datasourceName DB method
shreyabiradar07 Apr 23, 2024
1b562b2
Revert accidental DB constant push
shreyabiradar07 Apr 23, 2024
a598685
Implement delete metadata API
shreyabiradar07 Apr 23, 2024
23025dd
Remove unsed import statements
shreyabiradar07 Apr 23, 2024
9379994
Remove unused loadMetadata functionality
shreyabiradar07 May 15, 2024
901dbaf
Merge upstream branch 'mvp_demo' into refactor_import_metadata
shreyabiradar07 May 23, 2024
70147bd
Add refresh parameter to import metadata API
shreyabiradar07 May 30, 2024
38bfee3
Revert refresh parameter changes
shreyabiradar07 Jun 5, 2024
53f0fcb
Error handling using sendErrorResponse instead of throwing exceptions
shreyabiradar07 Jun 5, 2024
bfe7cfc
Refactor POST /dsmetadata and validate imported metadata object
shreyabiradar07 Jun 18, 2024
de96117
Refactor DELETE /dsmetadata and add java docs
shreyabiradar07 Jun 19, 2024
dff11a8
Add null check for DataSourceInfo
shreyabiradar07 Jun 20, 2024
2ed70f8
Refactor validation logic of metadata
shreyabiradar07 Jun 21, 2024
4b92180
Refactor common logic for processing workload and container metadata
shreyabiradar07 Jun 25, 2024
dfcc632
Update java docs
shreyabiradar07 Jun 25, 2024
d6aa841
Refactor save metadata to database reducing DB operations
shreyabiradar07 Jun 25, 2024
4759f6c
Move common code between create and update metadata functions
shreyabiradar07 Jun 25, 2024
1bae659
Remove redundant try-catch blocks
shreyabiradar07 Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/com/autotune/common/datasource/DataSourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ public void deleteMetadataFromDataSource(DataSourceInfo dataSource) {
*/
public void saveMetadataFromDataSourceToDB(DataSourceInfo dataSourceInfo) {
try {
if (null == dataSourceInfo) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyabiradar07 - As discussed, please add the negative scenario to bring down the prometheus by scaling down the statefulset and deployment between multiple imports, and validate that the second call to import metadata fails with appropriate error message and list metadata returns the metadata from the DB. This can be added in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrams - created #1211 adding a negative scenario to test multiple metadata imports by bringing down prometheus server instance following the above approach. Please review the same, thanks!

throw new DataSourceDoesNotExist(KruizeConstants.DataSourceConstants.DataSourceErrorMsgs.MISSING_DATASOURCE_INFO);
}

DataSourceMetadataInfo dataSourceMetadataInfo = dataSourceMetadataOperator.getDataSourceMetadataInfo(dataSourceInfo);
if (null == dataSourceMetadataInfo) {
LOGGER.error(KruizeConstants.DataSourceConstants.DataSourceMetadataErrorMsgs.DATASOURCE_METADATA_INFO_NOT_AVAILABLE, "for datasource {}" + dataSourceInfo.getName());
Expand Down Expand Up @@ -163,6 +167,9 @@ private boolean checkIfDataSourceMetadataExists(String dataSourceName) {
*/
public void deleteMetadataFromDBByDataSource(DataSourceInfo dataSourceInfo) {
try {
if (null == dataSourceInfo) {
throw new DataSourceDoesNotExist(KruizeConstants.DataSourceConstants.DataSourceErrorMsgs.MISSING_DATASOURCE_INFO);
}
String dataSourceName = dataSourceInfo.getName();
DataSourceMetadataInfo dataSourceMetadataInfo = fetchDataSourceMetadataFromDBByName(dataSourceName, "false");
if (null == dataSourceMetadataInfo) {
Expand Down
Loading