-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initContainer in Kruize pod to check PostGres pod readiness #1194
Conversation
758fb40
to
9c3dde1
Compare
9c3dde1
to
d7e42cb
Compare
@msvinaykumar Tested it on resource hub cluster, able to see it working on openshift as well
|
initContainer
in Kruize pod to check PostGres pod readiness
initContainer
in Kruize pod to check PostGres pod readiness
manifests/crc/BYODB-installation/minikube/kruize-crc-minikube.yaml
Outdated
Show resolved
Hide resolved
manifests/crc/BYODB-installation/openshift/kruize-crc-openshift.yaml
Outdated
Show resolved
Hide resolved
manifests/crc/default-db-included-installation/openshift/kruize-crc-openshift.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@khansaad can we change the name of the postgres service to |
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
39a7f6a
to
74c9182
Compare
Updated now! |
Signed-off-by: Saad Khan <saakhan@redhat.com>
@khansaad Sorry can you grep for the name postgres in the manifest files and update it something more relevant wherever appropriate, thanks! |
Signed-off-by: Saad Khan <saakhan@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@khansaad Looks like the PR check test scripts might need to be updated as well |
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
Signed-off-by: Saad Khan <saakhan@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add
initContainer
in Kruize pod to check postGres pod readinessDescription
This PR will do the following changes -
initContainer
which checks for the postgres pod service based and starts the main kruize container only when a successful connection is established.Type of change
How has this been tested?
Test Configuration
Checklist 🎯
Additional information