Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set box plots flag as true by default #1208

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Set box plots flag as true by default #1208

merged 1 commit into from
Jun 13, 2024

Conversation

khansaad
Copy link
Contributor

Set box plots flag as true by default

Description

This PR will do the following changes -

  • update the box plot flag in code from false to true so that it remains enabled by default

Type of change

  • Refactoring Code
  • New feature

How has this been tested?

  • Using kruize-demo scripts.
    Image: quay.io/kruize/autotune_operator:flag-update
  • Manually verified that the box plots are visible without passing the flag as env variable.

Test Configuration

  • Kubernetes clusters tested on: Minikube

Checklist 馃幆

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

@khansaad
update box plot flag to be true by-default
f9e4289 
Signed-off-by: Saad Khan <saakhan@redhat.com>
@khansaad khansaad added the bug Something isn't working label Jun 12, 2024
@khansaad khansaad added this to the Kruize 0.0.23_rm Release milestone Jun 12, 2024
@khansaad khansaad self-assigned this Jun 12, 2024
msvinaykumar
msvinaykumar approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@msvinaykumar msvinaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 10bad1d into kruize:mvp_demo Jun 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvinaykumar msvinaykumar msvinaykumar approved these changes

Assignees

@khansaad khansaad

Labels
bug Something isn't working
Projects
Remote Monitoring
Status: Done
Milestone
Kruize 0.0.23_rm Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khansaad @msvinaykumar @dinogun