update recommendations API optimalquery to fetch results #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
dinogun
reviewed
Aug 31, 2023
| sum_of_duration_in_mins += entry.getDuration_minutes(); | ||
| } | ||
|
|
||
| if (sum_of_duration_in_mins < KruizeConstants.RecommendationEngineConstants.DurationBasedEngine.DurationAmount.LONG_TERM_DURATION_DAYS * KruizeConstants.DateFormats.MINUTES_FOR_DAY) { |
There was a problem hiding this comment.
What happens when we have more records than is needed. Since you are setting the threshold as 10 days, you can get significantly more records than needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general strategy involves initially attempting the optimal query;
if the sum of duration is not matched and rowscount > optimal query count, then considering an alternative suboptimal query.
optimal query
select * from kruize_results k1_0 where k1_0.experiment_name=? and k1_0.interval_start_time>=? and k1_0.interval_end_time<=? order by k1_0.interval_end_time desc fetch first ? rows onlyhere interval_start_time = interval_end_time - (LONG_TERM_DURATION_DAYS + THRESHOLD 10 days)
suboptimal query
select * from kruize_results k1_0 where k1_0.experiment_name=? and k1_0.interval_end_time<=? order by k1_0.interval_end_time desc fetch first ? rows onlyRow Limit is