Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving folder structure #33

Open
wants to merge 2 commits into
base: mvp_demo
Choose a base branch
from

Conversation

ppadti
Copy link

@ppadti ppadti commented Jul 26, 2023

This PR aims to restructure the project folder to enhance the code organization. The changes includes moving components to dedicated directories and updatng imports accordingly.

  • moved all indivial components from 'app' to 'components' directory.
  • moved all major components from 'app' to 'pages' directory. etc

@bhanvimenghani
Copy link
Contributor

Reusable components (like drop down, bar chart etc) should be a part of the component folder, also App Layout should not be a part of Component folder.
I see u have changed folder structure for 2 files: RunExperiment and Regular Section, can u explain the reason for that

@ppadti
Copy link
Author

ppadti commented Jul 28, 2023

Reusable components (like drop down, bar chart etc) should be a part of the component folder, also App Layout should not be a part of Component folder. I see u have changed folder structure for 2 files: RunExperiment and Regular Section, can u explain the reason for that

App Layout is a generic component and independent of application logic, so I thought it move into components folder. However, if you think we should move App Layout out of components folder, no issue from my side. Just let me know your opinion.

And regarding RunExperiment and Regular Section, Could you please provide more context or specific details about this.

@bhanvimenghani
Copy link
Contributor

can we have a layouts folder inside of components and put app layout in that. Planning a standard folder structure that we can follow

@bhanvimenghani
Copy link
Contributor

bhanvimenghani commented Aug 31, 2023

Hi @ppadti the ui is not able to pick up Kruize port number for me and hence the List experiment api is not working. The dropdown menu for usecase selection showing Remote and Local option where as its supposed to show only Remote option as per latest (Kruize-ui , mvp_demo) branch. Can u check once

@ppadti
Copy link
Author

ppadti commented Aug 31, 2023

Hi @ppadti the ui is not able to pick up Kruize port number for me and hence the List experiment api is not working. I am also seeing some of the old UI files (like deploy.sh ) and the dropdown menu for usecase selection showing Remote and Local option where as its supposed to show only Remote option as per latest (Kruize-ui , mvp_demo) branch. Can u check once

Sure, I will check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants