Fix clippy errors except for the false positive described in rust-lan…

…g/rust-clippy#10390

src/main.rs

@@ -44,12 +44,12 @@ fn main() {
 
         for version in candidate.versions {
             let the_match = version.get_matching(name.clone(), available.clone());
-            the_match.map(|it| {
+            if let Some(it) = the_match {
                 required.insert(it.to_string());
                 if version.default.unwrap_or(false) {
                     default = Some(it.to_string());
                 }
-            });
+            }
         }
 
         let to_install = required.difference(&installed);

src/rules/mod.rs

@@ -32,7 +32,7 @@ pub trait VersionMatch {
 impl VersionMatch for Version {
     fn get_matching(&self, name: String, available: Vec<String>) -> Option<String> {
         let pattern = Regex::new(self.pattern.as_str())
-            .expect(format!("Invalid regex for {}: {}", name, self.pattern).as_str());
+            .unwrap_or_else(|_| panic!("Invalid regex for {}: {}", name, self.pattern));
         let mut matches: Vec<String> = available
             .iter()
             .filter(|it| pattern.is_match(it))
@@ -41,11 +41,8 @@ impl VersionMatch for Version {
 
         if let Some(exclude) = self.exclude.as_ref() {
             let exclude_pattern = Regex::new(exclude.join("|").as_str())
-                .expect(format!("Invalid regex for {}: {}", name, exclude.join("|")).as_str());
-            matches = matches
-                .into_iter()
-                .filter(|it| !exclude_pattern.is_match(it))
-                .collect();
+                .unwrap_or_else(|_| panic!("Invalid regex for {}: {}", name, exclude.join("|")));
+            matches.retain(|it| !exclude_pattern.is_match(it));
         }
 
         return matches.first().map(|it| it.to_string());

src/sdkman/candidate.rs

@@ -56,10 +56,11 @@ mod private {
                 } else if dashes_pattern.is_match(line) {
                     dashes += 1;
                 } else if equals == 2 && dashes == 1 {
-                    line.split_whitespace()
+                    if let Some(word) = line.split_whitespace()
                         .filter(|word| *word != "*" && *word != ">")
-                        .last()
-                        .map(|word| versions.push(word.to_string()));
+                        .last() {
+                        versions.push(word.to_string());
+                    }
                 }
             }
             versions

src/sdkman/mod.rs

@@ -19,6 +19,7 @@ pub struct SdkMan {
 }
 
 impl ToolManager for SdkMan {
+    #[allow(clippy::needless_return)]
     fn installed_versions(&self, candidate: String) -> Vec<String> {
         return match env::var("SDKMAN_DIR") {
             Ok(dir) => {