-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine grained progress + cancellation #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning in debug mode: Base object is dead, while nested/derived object is still alive or processed
simplifies code, skips timing code if disabled
With override for workflows that need the future like cli or tests. Moving the ownership is useful for including a simple queue of tasks + non-blocking cancel support
each tasks has an associated ProgressMonitor (with a separate cancellation flag)
…tions less options for weird state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fine grained progress bar when stitching, what was previously counted as a single step is now (8 + n_images):
There are also cancel checkpoints between all the steps, so that the computation can be quickly abandoned. This is useful when launching new stitching tasks e.g. when manually editing a panorama by ctrl clicking, see the video for an example:
xpano_cancel.mp4
images credit: Steven from https://monarophotography.au/
This feature required two big changes:
Using the forked Stitcher class will possibly allow modification for a 16-bit pipeline (#74)
Fixes #73