chore(*): Address cargo deny failures
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses all warnings and failures from `cargo deny` as a follow up to krustlet#641. It streamlines the allowed licenses for now. There are currently some warnings that will be fixed once kflansburg/k8s-csi#2 is merged. There are also 2 license warnings remaining. Both of them are from krator and will be fixed once there is a new version published to crates.io. Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
thomastaylor312
requested review from
bacongobbler,
kflansburg and
technosophos
as code owners
fibonacci1729
approved these changes
Aug 2, 2021
|
Moving this to draft because I realized the update to tonic is gonna involve some more updating and I'm sure it'll conflict with the stuff from k8s-csi |
This was
linked to
issues
Aug 3, 2021
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
thomastaylor312
force-pushed
the
fix/advisories
branch
from
e33b262
to
e2ac193
Compare
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
|
Note: I manually added the krator license hashes as a workaround. These should be removed once krator cuts a new version |
|
looks good but it appears some of the CI tests are failing. Specifically the |
|
I realized that they are using the |
|
Ok @bacongobbler this addresses everything but 1, which is under review at the CNCF for license exemption. Might as well approve this as is and then I'll come back and add the last one |
bacongobbler
approved these changes
Aug 10, 2021
|
I'll leave it to you to merge when ready |
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
radu-matei
pushed a commit
to radu-matei/krustlet
that referenced
this pull request
Sep 20, 2021
Following the same procedure ashttps://github.com/krustlet/pull/657, this commit adds `webpki-roots` in the list of crates with allowed licenses. Signed-off-by: Radu M <root@radu.sh>
thomastaylor312
pushed a commit
to krustlet/oci-distribution
that referenced
this pull request
Mar 2, 2023
Following the same procedure ashttps://github.com/krustlet/krustlet/pull/657, this commit adds `webpki-roots` in the list of crates with allowed licenses. Signed-off-by: Radu M <root@radu.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses all warnings and failures from
cargo denyas a followup to #641. It streamlines the allowed licenses for now. There are currently
some warnings that will be fixed once kflansburg/k8s-csi#2 is merged.
There are also 2 license warnings remaining. Both of them are from krator and
will be fixed once there is a new version published to crates.io.