Make CSRs compatible with Kubernetes v1.22 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The certificates.k8s.io/v1beta1 API version of CertificateSigningRequest is no longer served as of v1.22. The certificates.k8s.io/v1 API version is used instead which is available since v1.19. Signed-off-by: Siegfried Weber <mail@siegfriedweber.net>
siegfriedweber
requested review from
bacongobbler,
kflansburg,
technosophos and
thomastaylor312
as code owners
thomastaylor312
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Thanks for doing this! Just as a note for anyone else who stumbles onto this PR, #660 will bring us to fully operational battlestation k8s 1.22 status as we still need to update the underlying libraries as well
thomastaylor312
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
certificates.k8s.io/v1beta1API version ofCertificateSigningRequestis no longer served as of Kubernetes v1.22. Thecertificates.k8s.io/v1API version is used instead which is available since v1.19.The requirements of the new API version were already met:
This change makes kubelet incompatible with Kubernetes v1.18 and lower.
k8s-openapiis currently compiled with the featurev1_21which is okay because the new API is available sincev1_19.