-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate config properties #683
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yunkunrao. I appreciate that you added tests to accompany this change as well. LGTM!
@yunkunrao Looks like your tests are expecting a path that isn't there on the runner. You might need to generate a kubeconfig for the test to use |
I have refactored this PR and add a public method |
Thanks @yunkunrao. It looks like this is failing the DCO sign-off - one of the reverted commits is missing the "Signed-off-by" header required by the DCO. See https://github.com/krustlet/krustlet/pull/683/checks?check_run_id=3816534329 for more details I don't see any reason why the windows e2e tests failed. I'll try restarting those and see what happens. Try rebasing your commits onto |
Signed-off-by: rao yunkun <yunkunrao@gmail.com>
Got it. I have squashed commits to a single one. |
This is related with #589
Signed-off-by: rao yunkun yunkunrao@gmail.com