chore(*): Bumps krustlet to use the 2021 edition #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
requested review from
bacongobbler,
kflansburg and
technosophos
as code owners
thomastaylor312
changed the title
We've been tracking and using most of the latest features anyway, so this seems to make sense Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
|
NOTE: This cannot be merged until Github actions updates to 1.56 |
|
been tracking the progress of the 2021 edition for a while. LGTM once it goes live! |
kflansburg
approved these changes
Oct 21, 2021
| @@ -55,6 +55,7 @@ pub async fn pod_exited_successfully(pods: &Api<Pod>, pod_name: &str) -> anyhow: | |||
| let pod = pods.get(pod_name).await?; | |||
|
|
|||
| let state = (|| { | |||
| let _ = &pod; | |||
There was a problem hiding this comment.
Out of curiosity, what does this do? Does this make the closure capture the entire variable pod?
There was a problem hiding this comment.
cargo fix --edition did this for me, so I didn't want to mess with it
thomastaylor312
force-pushed
the
chore/2021_edition
branch
3 times, most recently
from
bd21254
to
ee35809
Compare
Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
thomastaylor312
force-pushed
the
chore/2021_edition
branch
from
ee35809
to
f587034
Compare
|
Going to merge as windows e2e is broken and the advisories are still known issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been tracking and using most of the latest rust features anyway, so
this seems to make sense