Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration, enable running alongside other server discovery systems, add API #66

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add configuration, enable running alongside other server discovery systems, add API #66

wants to merge 20 commits into from

Conversation

belohnung
Copy link

Features added

  • a way to configure the plugin with environment variables
  • a way for other plugins to get a list of server names the plugin has discovered
  • a way to change the way servers are named inside velocity

Fixes

  • the plugin now tries to find a container port named 'minecraft' to discover the minecraft port, it falls back to the original behaviour if there is more than one port found in a pod or none are.
  • the plugin now does not touch servers it itself hasn't discovered, this includes the server selection in the join listener

belohnung and others added 15 commits September 5, 2023 09:56
@belohnung
feat: implement a configuration
cbea47d 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: don't hardcode the container port to 25565
3d47129 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: don't remove servers not discovered by kryo-server-discovery
cfad729 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: wrong directive in server discovery task
2cf53a2 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: use server-name-format directive
336e1d1 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: wrong directive in server discovery task
86c62fc 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
chore: make configuration testable
26e8e8f 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
test: add tests for configuration
9a142ca 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
style: format
b0ac1fe 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
docs: add configuration instructions to readme & make Examples sectio…
efa54be 
…n clearer

Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: use container port instead of host port
a89158b 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: check if pod is ready before trying to construct server info
f48e03a 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
feat: expose discovered servers for consumption in other plugins
e4602db 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: only choose kryo-server-discovery discovered servers in join lis…
0db4119 
…tener

Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
fix: match default server-name-format directive to docs
67c8d8d
@lusu007
Copy link
Member

lusu007 commented Sep 7, 2023

Thank you for your contribution. I will have a look in the next days😊

lusu007
lusu007 requested changes Sep 16, 2023
View reviewed changes
Copy link
Member

@lusu007 lusu007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay. I only had time for a first little review. I'll review the code itself in the next few days during my available spare time.

.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/release-drafter.yaml Outdated Show resolved Hide resolved
.github/workflows/release-drafter.yaml Outdated Show resolved Hide resolved
.github/workflows/wrapper-validation.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/main/java/org/kryonite/kryoserverdiscovery/KryoServerDiscoveryPlugin.java Outdated Show resolved Hide resolved
src/main/java/org/kryonite/kryoserverdiscovery/serverdiscovery/ServerDiscoveryTask.java Outdated Show resolved Hide resolved
src/test/java/org/kryonite/kryoserverdiscovery/serverdiscovery/ServerDiscoveryTaskTest.java Outdated Show resolved Hide resolved
@belohnung
fix: make the server-name-format the same as it was before....
a7ec3af 
Signed-off-by: belohnung <belohnung@protonmail.com>
@belohnung
Copy link
Author

hi! any news?

@belohnung
Copy link
Author

bump

@lusu007
Copy link
Member

lusu007 commented Jan 22, 2024

Apologies for the delay in responding. At present, we have paused active maintenance on this project. Consequently, we are unable to merge this pull request as the future direction of the project remains uncertain.

I appreciate your understanding. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lusu007 lusu007 Awaiting requested review from lusu007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@belohnung @lusu007